Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deepsource: Potential slowloris attack #1834

Merged
merged 2 commits into from
Nov 18, 2022
Merged

fix deepsource: Potential slowloris attack #1834

merged 2 commits into from
Nov 18, 2022

Conversation

datelier
Copy link
Contributor

@datelier datelier commented Nov 17, 2022 •
edited
Loading

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 30.55% // Head: 30.55% // No change to project coverage 👍

Coverage data is based on head (995acd9) compared to base (63e6fcd).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1834   +/-   ##
=======================================
  Coverage   30.55%   30.55%           
=======================================
  Files         367      367           
  Lines       33777    33777           
=======================================
  Hits        10320    10320           
- Misses      23043    23045    +2     
+ Partials      414      412    -2
Impacted Files Coverage Δ
...ent/core/ngt/service/vqueue/undeleted_index_map.go 71.11% <0.00%> (-5.56%) ⬇️
internal/worker/worker.go 83.07% <0.00%> (+0.76%) ⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 73.22% <0.00%> (+4.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hlts2
hlts2 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4bd496
Status:⚡️  Build in progress...

View logs

@kpango kpango merged commit 05f223d into main Nov 18, 2022
@kpango kpango deleted the refactoring/GO-S2112/potential-slowloris-attack branch November 18, 2022 05:32
@kpango kpango mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@vankichi vankichi vankichi approved these changes

@kevindiu kevindiu kevindiu approved these changes

@kpango kpango Awaiting requested review from kpango

Assignees
No one assigned
Labels
area/internal priority/low size/S team/set SET team type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@datelier @vdaas-ci @kevindiu @vankichi @hlts2 @kpango